Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TokenNftAllowance #418

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Update TokenNftAllowance #418

merged 4 commits into from
Jul 19, 2023

Conversation

rwalworth
Copy link
Contributor

Description:
This PR adds missing APIs from TokenNftAllowance. It also removes TokenNftRemoveAllowance, as its not a part of the designate SDK APIs.

Related issue(s):

Fixes #417

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@rwalworth
Update TokenNftAllowance | Remove TokenNftRemoveAllowance as it is no…
2ec2fef 
…t required

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth rwalworth added the Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Jul 12, 2023
@rwalworth rwalworth requested a review from deyanzz July 12, 2023 16:22
@rwalworth rwalworth self-assigned this Jul 12, 2023
@rwalworth rwalworth linked an issue Jul 12, 2023 that may be closed by this pull request
Update TokenNftAllowance #417
Closed
deyanzz
deyanzz approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@deyanzz deyanzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwalworth rwalworth merged commit 46b15ee into main Jul 19, 2023
2 checks passed
@rwalworth rwalworth deleted the 00417-update-tokennftallowance branch July 19, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deyanzz deyanzz deyanzz approved these changes

Assignees

@rwalworth rwalworth

Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update TokenNftAllowance
2 participants
@rwalworth @deyanzz